fix: allow absolute paths to Dangerfile #1475
Merged
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We are using Danger within a Docker-container in our CI pipeline. As most of our pipelines use a central Danger configuration as well as standardized CI pipelines, Danger is not required to be setup in every single repository, but fully baked into our container.
The Dangerfile is placed alongside the required dependencies in a different path (
/app
) than the actual project (/workdir
).When running DangerJS with
--dangerfile /app/dangerfile.mjs
the path is joined withpath.cwd()
, resulting in an invalid path like/workdir/app/dangerfile.mjs
.Solution
Switching to
path.resolve
instead ofpath.join
resolves (pun intended) this, without impacting other use cases.